VTKLoader: Add support for AppendedData.#28816
Merged
Merged
Conversation
Collaborator
|
Do you mind sharing a VTK asset for testing? The one from your issue points to a 404 page: https://github.com/Mt-Youya/vanilla-oral/blob/main/public/assets/models/user-appendedData.vtp |
Contributor
Author
|
Oh! Sorry! I forget set public. It works now! |
Clean up.
More clean up.
Mugen87
changed the title
AppendedData.
Mugen87
approved these changes
Jul 5, 2024
Collaborator
Mugen87
left a comment
Mugen87
left a comment
There was a problem hiding this comment.
LGTM! The existing assets still work and user-appendedData.vtk from your test repo works now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #28815
Description
Add "AppendedData " format support.